0000461: missing shalls in interfaces new to Issue 7

Austin Group Defect Tracker

Aardvark Mark IV

Viewing Issue Simple Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Category

Severity

Type

Date Submitted

Last Update

0000461

[1003.1(2008)/Issue 7] System Interfaces

Editorial

Error

2011-06-07 20:57

2013-04-16 13:06

Reporter

eblake

View Status

public

Assigned To

ajosey

Priority

normal

Resolution

Accepted

Status

Closed

Name

Eric Blake

Organization

Red Hat

User Reference

ebb.shall

Section

fmemopen

Page Number

866

Line Number

28742

Interp Status

---

Final Accepted Text

Summary

0000461: missing shalls in interfaces new to Issue 7

Description

Among the added *at interfaces, some used "is used " while others used
"shall be used" (such as utimensat line 32391) when describing the
effects of AT_FDCWD; for consistency, all of these interfaces should
use "shall".

Additionally, the fmemopen( ) interface is missing a large number of
"shall" statements.

My audit of other interfaces listed in XRAT page 3494 didn't turn up
any other missing "shall"s.

Desired Action

Change "current working directory is used" to "current working
directory shall be used" in these interfaces:

line 19464 access (for faccessat)
line 22186 chmod (for fchmodat)
line 22353 chown (for fchownat)
line 31694 fstat (for fstatat)
line 40134 link (for linkat)
line 42327 mkdir (for mkdirat)
line 42523 mkfifo (for mkfifoat)
line 42673 mknod (for mknodat)
line 45296 open (for openat)
line 55862 readlink (for readlinkat)
line 65077 symlink (for symlinkat)
line 68031 unlink (for unlinkat)

At line 28742 [XSH fmemopen DESCRIPTION], change:

The mode argument is a character string having one of the following
values:

to this (matching fopen wording at line 29115):

The mode argument points to a string. If the string is one of the
following, the file shall be opened in the indicated mode. Otherwise,
the behavior is undefined.

At line 28757, change:

The stream maintains a current position in the buffer. This position is
initially set to either the beginning of the buffer (for r and w modes)
or to the first null byte in the buffer (for a modes). If no null byte
is found in append mode, the initial position is set to one byte after
the end of the buffer.

to

The stream shall maintain a current position in the buffer. This position
shall be initially set to either the beginning of the buffer (for r and
w modes) or to the first null byte in the buffer (for a modes). If no
null byte is found in append mode, the initial position shall be set to
one byte after the end of the buffer.

At line 28762, change:

The stream also maintains the size of the current buffer contents. For
modes r and r+ the size is set to the value given by the size argument.
For modes w and w+ the initial size is zero and for modes a and a+ the
initial size is either the position of the first null byte in the buffer
or the value of the size argument if no null byte is found.

to:

The stream shall also maintain the size of the current buffer contents;
use of fseek() or fseeko() on the stream with SEEK_END shall seek
relative to this size. For modes r and r+ the size shall be set to the
value given by the size argument. For modes w and w+ the initial size
shall be zero and for modes a and a+ the initial size shall be either
the position of the first null byte in the buffer or the value of the
size argument if no null byte is found.

At line 28766, change:

A read operation on the stream cannot advance the current buffer
position beyond the current buffer size. Reaching the buffer size in a
read operation counts as ‘‘end-of-file’’. Null bytes in the buffer
have no special meaning for reads. The read operation starts at the
current buffer position of the stream.

to:

A read operation on the stream shall not advance the current buffer
position beyond the current buffer size. Reaching the buffer size in a
read operation shall count as ‘‘end-of-file’’. Null bytes in the buffer
shall have no special meaning for reads. The read operation shall start
at the current buffer position of the stream.

At line 28770, change:

A write operation starts either at the current position of the stream
(if mode has not specified ’a’ as the first character) or at the current
size of the stream (if mode had ’a’ as the first character). If the
current position at the end of the write is larger than the current
buffer size, the current buffer size is set to the current position. A
write operation on the stream cannot advance the current buffer size
beyond the size given in the size argument.

to:

A write operation shall start either at the current position of the stream
(if mode has not specified ’a’ as the first character) or at the current
size of the stream (if mode had ’a’ as the first character). If the
current position at the end of the write is larger than the current
buffer size, the current buffer size shall be set to the current position.
A write operation on the stream shall not advance the current buffer size
beyond the size given in the size argument.

At line 28775, change:

When a stream open for writing is flushed or closed, a null byte is
written at the current position or at the end of the buffer, depending
on the size of the contents. If a stream open for update is flushed or
closed and the last write has advanced the current buffer size, a null
byte is written at the end of the buffer if it fits.

to:

When a stream open for writing is flushed or closed, a null byte shall
be written at the current position or at the end of the buffer, depending
on the size of the contents. If a stream open for update is flushed or
closed and the last write has advanced the current buffer size, a null
byte shall be written at the end of the buffer if it fits.

Issue History
Date Modified	Username	Field	Change
2011-06-07 20:57	eblake	New Issue
2011-06-07 20:57	eblake	Status	New => Under Review
2011-06-07 20:57	eblake	Assigned To	=> ajosey
2011-06-07 20:57	eblake	Name	=> Eric Blake
2011-06-07 20:57	eblake	Organization	=> Red Hat
2011-06-07 20:57	eblake	User Reference	=> ebb.shall
2011-06-07 20:57	eblake	Section	=> fmemopen
2011-06-07 20:57	eblake	Page Number	=> 866
2011-06-07 20:57	eblake	Line Number	=> 28742
2011-06-07 20:57	eblake	Interp Status	=> ---
2011-06-07 20:59	eblake	Relationship added	related to 0000456
2011-06-07 21:00	eblake	Relationship added	related to 0000396
2011-06-16 15:37	Don Cragun	Status	Under Review => Resolved
2011-06-16 15:37	Don Cragun	Resolution	Open => Accepted
2011-06-16 15:37	Don Cragun	Tag Attached: tc1-2008
2011-09-01 16:08	eblake	Relationship added	related to 0000487
2013-04-16 13:06	ajosey	Status	Resolved => Closed