View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001710 | Issue 8 drafts | Shell and Utilities | public | 2023-05-07 14:00 | 2024-06-11 09:12 |
| Reporter | rillig | Assigned To | |||
| Priority | normal | Severity | Editorial | Type | Omission |
| Status | Closed | Resolution | Accepted As Marked | ||
| Product Version | Draft 3 | ||||
| Name | Roland Illig | ||||
| Organization | |||||
| User Reference | |||||
| Section | make | ||||
| Page Number | 3113 | ||||
| Line Number | 104930 | ||||
| Final Accepted Text | 0001710:0006364 | ||||
| Summary | 0001710: Evaluate delayed-expansion macros in '!=' macro definition | ||||
| Description | Line 104930 lists the situations in which delayed-expansion macros are expanded. It is missing the right-hand side of a '!=' macro definition, as well as the right-hand side of a '+=' macro definition with an immediate-expansion macro on the left-hand side. | ||||
| Desired Action | Add the missing cases explicitly, or come up with a concise definition for all situations in which delayed-expansion macros have to be expanded. | ||||
| Tags | applied_after_i8d3, issue8 | ||||
|
|
Same topic, different line: In line 104933, after the words ':::= operator', insert 'or the += operator on an immediate-expansion macro'. |
|
|
On page 3113 line 104928 change:Delayed-expansion macros after the <equals-sign> in a macro definition shall not be evaluated until the defined macro is used in a rule or command, or before the <equals-sign> in a macro definition.to: Delayed-expansion macros after the <equals-sign> in macro definitions other than the :::=, !=, and += forms, and after the <equals-sign> in += form macro definitions where the macro named by string1 exists and is a delayed-expansion macro, shall not be evaluated until the defined macro is used in any of the following ways: |
|
|
Regarding the suggestion in 0001710:0006274, the special handling of "$$" is only applicable to :::= as it is the only one where double evaluation would happen otherwise. |
|
|
Regarding Note 0006357, the new text contains a double negation in the form of "other than … shall not be evaluated", which may be unnecessarily hard to understand, and it contains redundant content. Did you consider rewording the text to:Delayed-expansion macros after the <equals-sign> in macro definitions shall only be expanded during the macro definition if: […] Aren't all these details already covered by the sentence starting in line 104914? Maybe they don't need to be listed at all. |
|
|
> Did you consider rewording the text No, we didn't. We just took the existing structure and updated it to fix the conflicts with other parts of the text. > Aren't all these details already covered by the sentence starting in line 104914? Given that what we changed was done in order to resolve conflicts with other text, I suppose that does mean that the other text in question already covers it. (That's not just line 104914, but that line in combination with other parts.) So maybe it would work if we just change the text to: Delayed-expansion macros after the <equals-sign> in macro definitions other than the :::=, !=, and += forms, and after the <equals-sign> in += form macro definitions where the macro named by string1 exists and is a delayed-expansion macro, shall only be evaluated when the defined macro is expanded. |
|
|
Reopening so that we can consider changing to a resolution that doesn't repeat a lot of detail (with the consequent danger that it could get out of step in future). |
|
|
Proposed new resolution ... On page 3113 line 104928 change: Delayed-expansion macros after the <equals-sign> in a macro definition shall not be evaluated until the defined macro is used in a rule or command, or before the <equals-sign> in a macro definition.to: Delayed-expansion macros after the <equals-sign> in macro definitions other than the :::=, !=, and += forms, and after the <equals-sign> in += form macro definitions where the macro named by string1 exists and is a delayed-expansion macro, shall only be evaluated when the defined macro is expanded. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-05-07 14:00 | rillig | New Issue | |
| 2023-05-07 14:00 | rillig | Name | => Roland Illig |
| 2023-05-07 14:00 | rillig | Section | => make |
| 2023-05-07 14:00 | rillig | Page Number | => 3113 |
| 2023-05-07 14:00 | rillig | Line Number | => 104930 |
| 2023-05-07 14:03 | rillig | Note Added: 0006274 | |
| 2023-06-26 16:22 | geoffclare | Note Added: 0006357 | |
| 2023-06-26 16:24 | geoffclare | Final Accepted Text | => 0001710:0006357 |
| 2023-06-26 16:24 | geoffclare | Status | New => Resolved |
| 2023-06-26 16:24 | geoffclare | Resolution | Open => Accepted As Marked |
| 2023-06-26 16:24 | geoffclare | Tag Attached: issue8 | |
| 2023-06-26 16:27 | geoffclare | Note Added: 0006358 | |
| 2023-06-26 16:59 | rillig | Note Added: 0006359 | |
| 2023-06-26 17:01 | rillig | Note Edited: 0006359 | |
| 2023-06-27 09:16 | geoffclare | Note Added: 0006362 | |
| 2023-06-27 09:24 | geoffclare | Note Added: 0006363 | |
| 2023-06-27 09:24 | geoffclare | Status | Resolved => Under Review |
| 2023-06-27 09:24 | geoffclare | Resolution | Accepted As Marked => Reopened |
| 2023-06-27 09:26 | geoffclare | Note Added: 0006364 | |
| 2023-06-29 15:07 | geoffclare | Final Accepted Text | 0001710:0006357 => 0001710:0006364 |
| 2023-06-29 15:07 | geoffclare | Status | Under Review => Resolved |
| 2023-06-29 15:07 | geoffclare | Resolution | Reopened => Accepted As Marked |
| 2023-07-18 10:57 | geoffclare | Status | Resolved => Applied |
| 2023-07-18 10:57 | geoffclare | Tag Attached: applied_after_i8d3 | |
| 2024-06-11 09:12 | agadmin | Status | Applied => Closed |
